Re: [Xen-devel] [PATCH] support 1gb pages in guest page table walker

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 11:25 +0100 on 25 Jul (1311593146), Tim Deegan wrote:
> Also this function should be called from the CPUID trap handler to make
> sure we never advertise PSE1GB when we're not going to support it.  

Er, not this function exactly, since CPUID should report the feature
even when the guest's not in long_mode.  I think it needs a
hvm_pse1G_supported that can be called from CPUID, and then
guest_supports_1G_superpages() boils down to 
"(GUEST_PAGING_LEVEL >= 4) && hvm_pse1G_supported(v)"

Tim.
 
-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel