Re: [Xen-devel] [PATCH V2] hvmloader: Fix FADT table for QEMU Upstream.

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Jul 26, 2011 at 18:48, Keir Fraser <keir@xxxxxxx> wrote:
> Thinking about this some more I wonder whether this will be correct for old
> Qemu. Furthermore, we don't actually have a legacy/SMM component in our
> virtual firmware, so advertising the enable/disable mechanism via
> SMI_CMD_IOPORT is a bit pointless.
>
> Could we instead dynamically handle this in in hvmloader's acpi-handling
> code something like:
> Âif ( !SCI_EN ) // must be new qemu if so
> Â Âoutb(SMI_CMD_IOPORT, PIIX4_ACPI_ENABLE)
> ÂBUG_ON(!SCI_EN)

I just try that, and that works fine. So it's fine to me to do that
instead of providing an IOPort that is not handle by the
qemu-xen-legacy.

> Or alternatively, we should at least gate the setting of those FADT fields
> on such a check, it seems to me.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel