[Xen-devel] Re: [Qemu-devel] [PATCH] xen: Avoid useless allocation in Xen case.

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Aug 2, 2011 at 11:49, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>> The same applies to kvm, please generalize.
>
> Actually, qemu-kvm avoids this overhead today by making code_gen_alloc
> return immediately when kvm is on. Also not very beautiful.
>
> Can't we simply skip cpu_exec_init_all for any accel != TCG, e.g. by
> moving that call to tcg_init?

In the function cpu_exec_init_all(), the call to cpu_gen_init() (and I
suppose to io_mem_init()) is still required. So we can not move the
whole function to tcg_init().

But I can maybe use "if (!tcg_enabled())" instead of a check to xen.
Until no tcg code is use when kvm/xen is enabled.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel