Re: [Xen-devel] [PATCH 11/11] xen/hvm kdump: reset PV devices in crash kernel

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 1 Aug 2011, Olaf Hering wrote:
> > Considering that all the other patches in this series follow the
> > opposite strategy, that is closing stuff on shutdown, why are you trying
> > to close xenbus connections on boot here?
> > At this point I would rather be coherent and simply switch to
> > XenbusStateClosing or XenbusStateClosed in the shutdown path if
> > kexec_is_loaded.
> 
> To allow the kdump kernel to store the /proc/vmcore file somewhere, it
> has to get either storage or network access.  But the kdump kernel finds
> all devices in the Connected state, because the to-be-debugged kernel
> just crashed. So it has to reset the connection to the backend.
 
my point still stands: why are you doing it on kdump boot rather than
doing it on the shutdown path?
It would be more coherent with the other patches in the series.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel