[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2 of 3] Enable UEFI BIOS(OVMF) support in Xen-unstable HVM

On 09/08/2011 10:58, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:

>> Apart from the pci_setup hook I just emailed about, hopefully we can avoid
>> code duplication in the init_vm86_tss hook as well. I'm not sure why we even
>> need the hook -- I'll need to check what it's for with Ian Campbell (cc'ed).
> I dunno ;-) I had assumed it was a rombios specific thing when I
> refactored for SeaBIOS (which doesn't implement the hook).
> Thinking about it again is this VM86 TSS a hangover from the days where
> we used to "emulate" realmode using vm86 in the HVM guest context (IIRC
> that was called vmxassist?). Perhaps the hook can be simply dropped?

No, as you correctly surmised it is for Tim's
realmode-emulation-acceleration. It is applicable to all guests regardless
of BIOS. Shall I move it back out into common code in hvmloader.c, then?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.