Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl

[Keir Fraser <keir@xxxxxxx>]

On 09/08/2011 12:47, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> I wrote:
>> Sadly this means we can't easily see when the other bug was
>> introduced.  I will see if I can do the bisection by hand, applying
>> 23742 to each commit.
> 
>   1d1692ac1a9b1f183a234736fd5196d7048562dc is first bad commit
>   commit 1d1692ac1a9b1f183a234736fd5196d7048562dc
>   Author: Liu, Jinsong <jinsong.liu@xxxxxxxxx>
>   Date:   Sat Jul 23 08:55:59 2011 +0100
> 
>       acpi: Add support for old and new bios erst, enable mce_apei logic

If it's really this changeset it's a bit weird. It would have to be due to
the more permissive table validation causing us to enable ACPI ERST support
based on a bad BIOS table, or a table which for some reason we're not
supporting properly, or a class of machines (e.g., AMD) for which our ERST
logic is not currently implemented properly.

Does reverting just the change to erst_check_table() fix the regression on
the affected test boxes? What about the similar-looking boot failure that
you see, Jeremy?

 -- Keir

>       When testing, we found different bios has different understanding
>       about APEI ERST table header, depending on whether it count ACPI
>       standard header or not.
>       This patch add support for both bios version, and enable mce_apei.
> 
>       Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>
> 
>   :040000 040000 93ae5d0dd96848631153860c08e6c68cf012d3ff
> 89b2cdaf4ba0546074680174809976d8371edbde M   xen
> 
> This corresponds to:
> 
>   changeset:   23736:31683aa4bfb3
>   user:        Liu, Jinsong <jinsong.liu@xxxxxxxxx>
>   date:        Sat Jul 23 08:55:59 2011 +0100
>   files:       xen/arch/x86/cpu/mcheck/Makefile xen/drivers/acpi/apei/erst.c
>   description:
>   acpi: Add support for old and new bios erst, enable mce_apei logic
> 
>   When testing, we found different bios has different understanding
>   about APEI ERST table header, depending on whether it count ACPI
>   standard header or not.
>   This patch add support for both bios version, and enable mce_apei.
> 
>   Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel