Re: [Xen-devel] [PATCH] libvchan: interdomain communications library

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

Hi Daniel,

On Fri, 2011-08-19 at 15:38 +0100, Daniel De Graaf wrote:

Please could you say a few words about the functionality this new
library enables and perhaps the design etc? In particular a protocol
spec would be useful for anyone who wanted to reimplement for another
guest OS etc. In particular memory barriers are conspicuous in their
absence.

I didn't review in detail but it seems like you have invented your own
ring datastructures rather than using the standard ring.h ones. I think
this needs some justification.

I think it would be appropriate to add protocol.txt at the same time as
checking in the library.

In one of the headers it says "The grant reference is expected to be
shared through some out-of-band mechanism such as XenStore." but the
library appears to implement the xenstore stuff internally.

>  tools/libvchan/gntalloc.h    |   82 ++++++++
>  tools/libvchan/gntdev.h      |  150 ++++++++++++++

If these define a Linux ioctl interface then they should go in
tools/include/xen-sys/Linux/.

>  tools/libvchan/libvchan.h    |  141 +++++++++++++

I presume that somewhere in there a shared datastructure is defined. In
which case that might be better off added to xen/include/public/io/
instead.

Cheers,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel