Re: [Xen-devel] [PATCH] Fix non-debug build after c/s 23767:80e9fcdaef36

[Tim Deegan <tim@xxxxxxx>]

At 15:02 +0100 on 22 Aug (1314025327), George Dunlap wrote:
> That seems to compile just fine, and obviously makes the code a lot
> cleaner.  The only thing is that this will still cause functions
> inside ASSERTS (spin_is_locked() in this case) to be called; I thought
> part of the reason for having ASSERTs in the debug build only was to
> reduce the cost of all the checks (the other reason to avoid
> unnecessary crashes on production builds)?

How about #define ASSERT(p) do { if (0 && (p)); } while (0) ?

Tim.

> On Mon, Aug 22, 2011 at 2:35 PM, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> > George,
> >
> > Would something like this work more generically for the non-debug case?
> >
> > #define ASSERT(p) do { if (p); } while (0)
> >
> >  -- Keir
> >

-- 
Tim Deegan <tim@xxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel