[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its watches using XS_RESET

On Thu, Aug 25, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH] xenstored: allow guests to shutdown 
> all of its watches using XS_RESET"):
> > Add a new XS_RESET command to do the reset on behalf of the guest.
> I'm afraid I still think this is wrong.

There is a later patch XS_RESET_WATCHES.

> * The XS_RESET command as you have it takes too many arguments.  It
>   should probably not take any arguments at all.

The later patch does not take arguments.

> * You have failed to update the specification document which describes
>   the xenstored protocol (in docs/misc/)

The later patch adds the XS_RESET_WATCHES part to the xenstored.txt.

> * Your XS_RESET command doesn't just delete watches and transactions.
>   It also:
>      - discards outstanding responses to earlier commands
>      - discards potential incoming partial commands
>      - resets the ring pointers
>   I don't think any of these things are necessary.  If they are,
>   please explain.  I think you should have your do_reset simply call
>   conn_delete_all_watches and conn_delete_all_transactions.

Thats what the later patch does.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.