Re: [Xen-devel] [PATCH] p2m: use defines for page sizes

[Tim Deegan <tim@xxxxxxx>]

At 14:44 +0200 on 25 Aug (1314283453), Christoph Egger wrote:
> 
> Use defines for page sizes instead of hardcoding the value.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Applied, thanks, except for this hunk, where that's not waht 9 means: 

> --- a/xen/arch/x86/mm/p2m-pt.c        Tue Aug 23 14:34:15 2011 +0200
> +++ b/xen/arch/x86/mm/p2m-pt.c        Thu Aug 25 14:29:18 2011 +0200
> @@ -64,7 +64,7 @@ static unsigned long p2m_type_to_flags(p
>       */
>      flags = (unsigned long)(t & 0x7f) << 12;
>  #else
> -    flags = (t & 0x7UL) << 9;
> +    flags = (t & 0x7UL) << PAGE_ORDER_2M;
>  #endif
>  
>  #ifndef __x86_64__

Cheers,

Tim.

-- 
Tim Deegan <tim@xxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel