Re: [Xen-devel] [PATCH 01/04] p2m: use defines for page sizes rather hardcoding them

[Tim Deegan <tim@xxxxxxx>]

At 09:45 +0100 on 01 Sep (1314870353), Tim Deegan wrote:
> At 09:40 +0100 on 01 Sep (1314870041), Tim Deegan wrote:
> > Content-Description: xen_superpage1.diff
> > > use defines for page sizes rather hardcoding them.
> > > 
> > > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> > 
> > Applied, thanks.  
> 
> The rest of this series looks OK in principle but I haven't time to look
> at the detail today (and I'm wondering whether there's a way of doing it
> without adding yet another argument to the p2m interfaces, but I suspect
> not).   I'll get to it as soon as I can.

I've had a look and the mechanism is good, but the patches are not quite
ready.  Patch #2 touches too much of the p2m interfaces with the new
page-order argument -- there are functions in it that now have a new
argument that's _never_ called except with NULL.

Patches #4 and #5 have a lot of churn in and around spage_* for what's
basically a mask operation on an MFN.  I don't think any of it is
necessary.  Also, please don't send patches that contain things like: 

+/* XXX: defines should be moved to a proper header */

It might make me think you didn't re-read them before posting. :)

I think they really just need trimmed back a bit before they go in.
I'll have some time on Wednesday, so I might just do that then.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel