[Xen-devel] Re: Dom0 ACPI S3 patches

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Sep 14, 2011 at 10:11:56AM +0200, Adi Kriegisch wrote:
> Dear Konrad,
> 
> just to let you know: I am using your patches[1] on my notebook (Thinkpad

Excellent. Is it OK if I put 'Tested-by: Adi Kriegish" on them?

> T61p) and they are working perfectly fine for me. I encountered three issues

Wait, T61p.. Can you actually do 64-bit on that laptop?Or are you using
a 32-bit hypervisor?

> which I could solve:
> * Machine crashes some time after wakeup with "BUG: unable to handle kernel
>   NULL pointer dereferenced at (null)". The crashing process was sshd as I
>   am forwarding my window manager from a DomU to X with nouveau running on
>   Dom0 with sdm.
>   I fixed that by setting all interrupts in the BIOS to "auto-select"
>   instead of the fixed default of "IRQ11". Since then I had no more crashes.

Ok, any other data? Stack trace?

> * The DomUs do not resync their clock after Dom0 waking up. They're
>   basically continue to count the time as if the sleep never happened.
>   I have to run 'ntpdate' on resume on all the DomUs. I am not sure if
>   there are any side effects of this; probably there is a more simple way
>   to tell a DomU to reread clock from Dom0?

You know, I don't know. I just never thought about that - um. I wonder
if it is related to the RTC update patch that I've been meaning
to take a look at:

http://lists.xensource.com/archives/html/xen-devel/2010-02/msg00469.html

> * vbetool hangs at 100% CPU on resume (i/o waiting, I guess, because
>   neither strace nor ltrace do show any activity). Simply killing vbetool
>   (no -9) kind of "fixes" the issue. Probably I do not even need to run
>   vbetool on resume.

Why do you run it? Anyhow there is a patch for vbetool to work
correctly with Nvidia drivers .. somewhere. ah, here.

diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index 1256454..3d91e46 100644
--- a/drivers/char/mem.c
+++ b/drivers/char/mem.c
@@ -316,9 +316,14 @@ static int mmap_mem(struct file *file, struct 
vm_area_struct *vma)
                        &vma->vm_page_prot))
        return -EINVAL;
 
-   vma->vm_page_prot = phys_mem_access_prot(file, vma->vm_pgoff,
-                        size,
-                        vma->vm_page_prot);
+   vma->vm_flags |= VM_RESERVED | VM_IO | VM_PFNMAP | VM_DONTEXPAND;
+   vma->vm_page_prot =  __pgprot(
+           pgprot_val(vm_get_page_prot(vma->vm_flags)) |
+           _PAGE_IOMAP |
+           pgprot_val(phys_mem_access_prot(file,
+               vma->vm_pgoff,
+               size,
+               vma->vm_page_prot)));
 
    vma->vm_ops = &mmap_mem_ops;
 


> 
> Anyways, thank you very much for your efforts in bringing decent Dom0
> support to upstream kernel! Your patches applied cleanly to the
> Debian/testing package linux-image-3.0.0-1-amd64 (3.0.0-3) and work just
> fine!

Woot!

> 
> best regards,
>     Adi Kriegisch
> 
> [1] http://lists.xensource.com/archives/html/xen-devel/2011-08/msg01358.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel