Re: [Xen-devel] [PATCH] IRQ Cleanup: rename nr_ioapic_registers to nr_ioapic_entries

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 26/09/2011 08:45, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:

>> I guess it depends on whether you consider that we should stay in line
>> with Linux or not.  While the code did start in Linux, it has diverged
> 
> Stay. Intel does a lot of work of "lift from Linux" and drop in Xen
> code. There is similarity.

You might also say it gives a false sense of similarity. Andrew's now having
to go fix the per-cpu vector stuff for example. It got dropped in; it was
complex and opaque; it doesn't really work properly yet. I'd prefer the
people doing the porting to have to think about each line a bit more.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel