[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Re: [PATCH] tools/check: check for yajl (needed by libxl)
On Fri, 2011-09-30 at 13:15 +0100, Olaf Hering wrote: > On Fri, Sep 30, Ian Campbell wrote: > > > On Fri, 2011-09-30 at 13:02 +0100, Olaf Hering wrote: > > > On Fri, Sep 30, Ian Campbell wrote: > > > > > > > (note to committer, ensure the new file is executable) > > > > > > Please dont, thats not patch friendly. > > > > > > Shouldnt all script files be called with like > > > '$interpreter $script' instead of './$script'? > > > > In general I agree, but that isn't how it the infrastructure in > > tools/check/chk works right now. > > There is tools/check/check_logging, which says it requires code with is > included in Python 2.3 and later. > The toplevel README states 2.3 or later is required, so > tools/check/check_logging could be removed and line 63 in > tools/check/chk be updated. Patches accepted, I don't think this should block the patch in this thread though. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |