[Xen-devel] Re: [PATCH RFC 7/8] s390/jump-label: add arch_jump_label_transform_early()

[Jan Glauber <jang@xxxxxxxxxxxxxxxxxx>]

On Thu, 2011-09-29 at 16:26 -0700, Jeremy Fitzhardinge wrote:
> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> 
> This allows jump-label entries to be modified early, in a pre-SMP
> environment.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> Cc: Jan Glauber <jang@xxxxxxxxxxxxxxxxxx>

Hi Jeremy,

Your patch looks fine, if you can fix the minor compiler warnings
below. Excluding stop_machine() on pre-SMP also looks safer too me.

--Jan

  CC      arch/s390/kernel/jump_label.o
arch/s390/kernel/jump_label.c: In function â__jump_label_transformâ:
arch/s390/kernel/jump_label.c:41:2: error: ârcâ undeclared (first use in this 
function)
arch/s390/kernel/jump_label.c:41:2: note: each undeclared identifier is 
reported only once for each function it appears in
arch/s390/kernel/jump_label.c:41:2: warning: passing argument 1 of 
âprobe_kernel_writeâ makes pointer from integer without a cast [enabled by 
default]
include/linux/uaccess.h:108:21: note: expected âvoid *â but argument is of type 
âjump_label_tâ
arch/s390/kernel/jump_label.c:28:19: warning: unused variable âargsâ 
[-Wunused-variable]
make[2]: *** [arch/s390/kernel/jump_label.o] Error 1



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel