Re: [Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial device is configured

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Oct 4, 2011 at 14:45, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1317735934 -3600
> # Node ID a0b8388fc4c82e345377679f4bffe7ab5d9eb55d
> # Parent Âc344d6d30b0f3796ebff069d6ecdde481c9e6a32
> libxl: remove QMP warning when no pty style serial device is configured
>
> If the serial device is not "pty" then there is nothing to do but this is not
> an error. Removes a spurious warning if e.g. serial="file:/tmp/serial.log" is 
> used:
>
> libxl: error: libxl_qmp.c:137:register_serials_chardev_callback: Failed to 
> store serial port information in xenstore: No such file or directory
>
>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> diff -r c344d6d30b0f -r a0b8388fc4c8 tools/libxl/libxl_qmp.c
> --- a/tools/libxl/libxl_qmp.c  Tue Oct 04 14:43:56 2011 +0100
> +++ b/tools/libxl/libxl_qmp.c  Tue Oct 04 14:45:34 2011 +0100
> @@ -87,7 +87,7 @@ static int store_serial_port_info(libxl_
> Â Â int ret = 0;
>
> Â Â if (!(chardev && strncmp("pty:", chardev, 4) == 0)) {
> - Â Â Â Âreturn -1;
> + Â Â Â Âreturn 0;
> Â Â }
>
> Â Â path = libxl__xs_get_dompath(&gc, qmp->domid);

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel