Re: [Xen-devel] [PATCH] xenbus: Fix loopback event channel assuming domain 0

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Daniel De Graaf writes ("[Xen-devel] [PATCH] xenbus: Fix loopback event channel 
assuming domain 0"):
> The xenbus event channel established in xenbus_init is intended to be a
> loopback channel, but the remote domain was hardcoded to 0; this will
> cause the channel to be unusable when xenstore is not being run in
> domain 0.

I'm not sure I understand this.

...
>               /* Next allocate a local port which xenstored can bind to */
>               alloc_unbound.dom        = DOMID_SELF;
> -             alloc_unbound.remote_dom = 0;
> +             alloc_unbound.remote_dom = DOMID_SELF;

The comment doesn't suggest that this is supposedly a loopback channel
(ie one for use by the xenbus client for signalling to itself,
somehow).

Rather it's supposed to be a channel to xenstore.  So the remote
domain should be the xenstore domain, which should come from the
shared info page.

Have you actually tested this with a separate xenstored domain ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel