Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification

[Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>]

On 10/07/2011 09:51 AM, Ian Campbell wrote:
> On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
> > XEN_ROOT must be set to an absolute path to avoid out of the tree references
> How about:
>
> # HG changeset patch
> # User Ian Campbell<ian.campbell@xxxxxxxxxx>
> # Date 1317973741 -3600
> # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
> # Parent  f17f0df2a2ede01a8c35dc4768a532a4438b1c02
> tools: error out on non-absolute $(XEN_ROOT)
>
> Signed-off-by: Ian Campbell<ian.campbell@xxxxxxxxxx>
Acked-by: juergen.gross@xxxxxxxxxxxxxx
> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
> --- a/tools/Rules.mk    Wed Oct 05 10:43:41 2011 +0100
> +++ b/tools/Rules.mk    Fri Oct 07 08:49:01 2011 +0100
> @@ -3,6 +3,10 @@
>   # `all' is the default target
>   all:
>
> +ifeq ($(filter /%,$(XEN_ROOT)),)
> +$(error XEN_ROOT must be absolute)
> +endif
> +
>   include $(XEN_ROOT)/Config.mk
>
>   export _INSTALL := $(INSTALL)
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

--
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel