[Xen-devel] Re: [PATCH] libxlu: correctly parse disk "backendtype" field

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-10-07 at 21:50 +0100, Daniel De Graaf wrote:
> The expression for backendtype was missing a comma.

This appears correct even though things seem to work without, at least:
xl -N block-attach 0 
backendtype=phy,vdev=xvdb,access=w,target=/dev/vg/guest-volume
works as expected. Do you have a test case which fails or did you just
find by code inspection?

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(we need a signed-off-by I suspect)

> 
> --- a/tools/libxl/libxlu_disk_l.l
> +++ b/tools/libxl/libxlu_disk_l.l
> @@ -139,7 +139,7 @@ devtype=disk,?    { DPC->disk->is_cdrom = 0; }
>  devtype=[^,]*,?      { xlu__disk_err(DPC,yytext,"unknown value for type"); }
>  
>  access=[^,]*,?       { STRIP(','); setaccess(DPC, FROMEQUALS); }
> -backendtype=[^,]*? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
> +backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
>  
>  vdev=[^,]*,? { STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
>  script=[^,]*,?       { STRIP(','); SAVESTRING("script", script, FROMEQUALS); 
> }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel