Re: [Xen-devel] [PATCH 2 of 2] build: append YAJL_CLFAGS and YAJL_LDFLAGS to libxl build

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH 2 of 2] build: append 
YAJL_CLFAGS and YAJL_LDFLAGS to libxl build"):
> I've took a look at how EXTRA_LIB and EXTRA_INCLUDES are handled, and
> found that they are appended to CFLAGS and LDFLAGS, so it's mostly the
> same using CFLAGS or EXTRA_INCLUDES. The best way I've come up to
> solve this is to modify each makefile and append EXTRA_LIB and
> EXTRA_INCLUDES at the end, but this means modifying a lot of
> makefiles. What do you think?

I'm not convinced that we should change the semantics of existing
variables, even if they are rather misnamed.

In principle changing every Makefile for this is a possibility but
we'd have to think properly about exactly what the global change
should be.

To me the most obvious possibility would be to modify the pattern
rule for compilation (tools/Rules.mk) to add a new variable at the end
of the compilation lines, just after "-o $@".

AFAICT link lines would indeed need a change to each one.

What should the new variables be called ?

 FINAL_CFLAGS_COMPILE
 FINAL_CFLAGS_LINK

?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel