[Xen-devel] Re: [PATCH 0 of 2] Patches to alter BLKIF_OP_TRIM to BLKIF_OP_DISCARD (v3)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2011-10-12 at 16:18 +0100, Konrad Rzeszutek Wilk wrote:
> This is the v3 of the patches. I've split the patch in two to cover just
> the documentation, and then the structure change. The structure change
> is the same, except the name of the 'secure' flag is BLKIF_DISCARD_SECURE
> now.

What I meant was to post the s/trim/discard/ (of both the docs and the
struct) as a separate patch with no other non-mechanical changes first.
As it stands the docs patch is unreadable because basically every line
has changed _and_ you've simultaneously added new content. The stuff
which has been added is the interesting bit WRT reviewing it, the rename
itself can be reviewed just by understanding the old and new names.

Once you've done the rename then you can add the docs and datastructures
relating to secure discard as a single patch, the stuff to do with
granularity as a patch etc etc. Currently you modify the datastructure
in your 2/2 patch but document the meaning of the new fields all mixed
up in patch 1/2.

> 
> I've also taken the liberty of applying Acked-by: Jan Beulich on both
> of the patches.
> 
> Please apply these two patches to the tree at your convience. Thanks.
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel