Re: [Xen-devel] Re: [PATCH] xen/gntdev: Fix sleep-inside-spinlock

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Oct 14, 2011 at 11:57:05AM +0200, Dario Faggioli wrote:
> On Tue, 2011-10-11 at 15:16 -0400, Daniel De Graaf wrote:
> > gntdev_put_map tries to acquire a mutex when freeing pages back to the
> > xenballoon pool, so it cannot be called with a spinlock held. In
> > gntdev_release, the spinlock is not needed as we are freeing the
> > structure later; in the ioctl, only the list manipulation needs to be
> > under the lock.
> > 
> > Reported-By: Dario Faggioli <raistlin@xxxxxxxx>
> > Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> >
> Ok, I finally manage in testing this, and it actually cures the issue
> here!
> 
> You can add a tested-by tag if you like. Just, if you don't mind, use my
> corp. e-mail for (both?) the tag(s): <dario.faggioli@xxxxxxxxxx>

Sure. Thx for checking it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel