Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

> This looks reasonable to me, although the commit message still talks
> about EXTRA_*. ÂIs everyone happy with the name
> USER_{LDFLAGS,CFLAGS} ?

In .config extra libraries and includes should be defined with
EXTRA_INCLUDES and EXTRA_LIB (the same way it is now), USER_LDFLAGS
and USER_CFLAGS is an internal make variable, and should not be set
directly by the user. Notice the lines:

+USER_LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i))
+USER_CFLAGS += $(foreach i, $(EXTRA_INCLUDES), -I$(i))

EXTRA_LIB and EXTRA_INCLUDES is added to USER_LDFLAGS and USER_CFLAGS
instead of LDFLAGS and CFLAGS.

> I'll give people a few days to comment, but I'm inclined to apply this
> one.
>
> Thanks,
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel