[Xen-devel] Re: [PATCH] Improve GPT support in pygrub

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2011-10-19 at 08:31 +0100, M A Young wrote:
> On Wed, 19 Oct 2011, Paolo Bonzini wrote:
> 
> > On 10/17/2011 07:03 PM, Konrad Rzeszutek Wilk wrote:
> >>> >  Check all GPT partitions for grub configuration, not just the first
> >>> >  Signed-off-by: Michael Young<m.a.young@xxxxxxxxxxxx>
> >> Tested-by: Konrad Rzeszutek Wilk<konrad.wilk@xxxxxxxxxx>
> >
> > You may need more to handle correctly this line:
> >
> >   set default="${saved_entry}"
> >
> > but this can be done in a separate patch.
> 
> Yes, there is this and 3 other issues that I was intending to submit as 
> separate patches for. Briefly the other issues are
> * Fedora 16 uses /boot/grub2 not /boot/grub
> * the Fedora 16 grub2 configurations can have partitions references like 
> (hd0,gpt2)
> * Fedora 16 can have submenus

I think it would be useful to have an archive of the different syntaxes
which we need to support. We should encourage folks who are fixing
pygrub to work on a particular distro to also submit an example of a
standardish configuration file as a patch to e.g.
tools/pygrub/examples/<distro>.grub (or .grub2 if that's appropriate).

IOW please include an example f16 config in your series ;-)

If someone is feeling ultra keen they could even write a little
regression tester framework to iterate over the examples and ensure they
produce something sane...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel