Re: [Xen-devel] [PATCH 4 of 9] libxl: create pci backend only when there are pci devices

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2011-10-19 at 10:11 +0100, Roger Pau Monnà wrote:
> 2011/10/18 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> > On Fri, 2011-09-30 at 13:43 +0100, Roger Pau Monne wrote:
> >> # HG changeset patch
> >> # User Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
> >> # Date 1317386335 -7200
> >> # Node ID 156626fef95b36184ad44dfcb049bae2545435f0
> >> # Parent  31b3caad18ac904a242c5bd1ea2bb0e574cd0453
> >> libxl: create pci backend only when there are pci devices.
> >>
> >> Creating empty pci entries made Linux DomUs under NetBSD Dom0 wait a
> >> very long time for devices to initialize during kernel boot.
> >
> > I think since this change we need the following. This applies after my
> > big libxl API series:
> 
> Yes, this fixes the issue related to the error message "libxl: error:
> libxl.c:759:libxl_domain_destroy: pci shutdown failed for domid". I
> don't know if I can do this, but anyway:
> 
> Acked-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>

Thanks. FWIW I would encourage anyone who wants and feels qualified to
do so to review any patch and Ack it if they think it is sensible. More
eyes doing review is always a good thing IMHO.

> 
> > Ian.
> >
> > 8<------------------------------------------------------
> >
> >
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> > # Date 1318943709 -3600
> > # Node ID e6af32ecb4483457d5ad9a7b674c18aaf20cc085
> > # Parent  12ac478d1b56f0ff4d3242138b780c551a69f107
> > libxl: libxl__device_pci_destroy_all should succeed if there is no PCI bus 
> > on the domain
> >
> > Since 23915:4c4b72c94bac "" it is possible that no bus exists and this is 
> > not
> > an error. Removes the following spurious warning when destroying a PV domain
> > with no PCI devices:
> >    libxl: error: libxl.c:759:libxl_domain_destroy: pci shutdown failed for 
> > domid 1005
> >
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> > diff -r 12ac478d1b56 -r e6af32ecb448 tools/libxl/libxl_pci.c
> > --- a/tools/libxl/libxl_pci.c   Tue Oct 18 13:36:43 2011 +0100
> > +++ b/tools/libxl/libxl_pci.c   Tue Oct 18 14:15:09 2011 +0100
> > @@ -1098,7 +1098,7 @@ int libxl__device_pci_destroy_all(libxl_
> >
> >     pcidevs = libxl_device_pci_list(ctx, domid, &num);
> >     if ( pcidevs == NULL )
> > -        return ERROR_FAIL;
> > +        return 0;
> >
> >     for (i = 0; i < num; i++) {
> >         /* Force remove on shutdown since, on HVM, qemu will not always
> >
> >
> >



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel