Re: [Xen-devel] [PATCH 18 of 27 v3] libxl: merge libxl__device_del into libxl__device_remove

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2011/10/19 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> On Wed, 2011-10-19 at 11:22 +0100, Roger Pau Monnà wrote:
>> > + Â Âxs_watch(ctx->xsh, state_path, be_path);
>> > + Â Âlibxl__device_destroy_tapdisk(gc, be_path);
>> > +
>> > + Â Âif (wait) {
>> > + Â Â Â Âstruct timeval tv;
>> > + Â Â Â Âtv.tv_sec = LIBXL_DESTROY_TIMEOUT;
>> > + Â Â Â Âtv.tv_usec = 0;
>> > + Â Â Â Â(void)wait_for_dev_destroy(gc, &tv);
>>
>> I think we should check the return value of wait_for_dev_destroy here,
>> since it might timeout, and the device is not removed then, so
>> libxl__device_remove should return 1 in that case (whereas it always
>> returns 0 now in that case, even when the device is still being
>> watched).
>
> Sure, didn't you post such a patch recently?

Yes, it was for the old version of your series and also included the
fix for libxl__device_remove always returning 0, I will modify it to
strip the now unnecessary parts and repost.

> Ian.
>
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel