[Xen-devel] Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough.

[Peter Maydell <peter.maydell@xxxxxxxxxx>]

On 19 October 2011 14:56, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
> +if test "$xen_pci_passthrough" != "no"; then
> + Âif test "$xen" = "yes" -a "$linux" = "yes"; then
> + Â Âxen_pci_passthrough=yes
> + Âelse
> + Â Âif test "$xen_pci_passthrough" = "yes"; then
> + Â Â Âfeature_not_found "Xen PCI Passthrough without Xen or not on linux"
> + Â Âfi
> + Â Âxen_pci_passthrough=no
> + Âfi
> +fi

The -a flag to test is obsolete -- don't use it in new code.
This is a bit of a misuse of the feature_not_found function IMHO.
(Also, Linux needs a capital letter.)

-- PMM

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel