Re: [Xen-devel] [PATCH RFC v2 05/13] libxl: idl: Provide struct and union tags

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-10-28 at 19:37 +0100, Ian Jackson wrote:
> Instead of generating:
> 
>    typedef struct {
>      ...
>    } libxl_foo;
> 
> Produce:
> 
>    typedef struct libxl_foo {
>      ...
>    } libxl_foo;
> 
> This makes it possible to refer to libxl idl-generated structs and
> unions, as incomplete types, before they have been defined.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxl/gentypes.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/gentypes.py b/tools/libxl/gentypes.py
> index e82b706..c4efbf3 100644
> --- a/tools/libxl/gentypes.py
> +++ b/tools/libxl/gentypes.py
> @@ -56,7 +56,7 @@ def libxl_C_type_define(ty, indent = ""):
>          if ty.typename is None:
>              s += "%s {\n" % ty.kind
>          else:
> -            s += "typedef %s {\n" % ty.kind
> +            s += "typedef %s %s {\n" % (ty.kind, ty.typename)
>  
>          for f in ty.fields:
>              if f.comment is not None:



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel