Re: [Xen-devel] [PATCH RFC v2 00/13] New event API

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-10-28 at 19:36 +0100, Ian Jackson wrote:
> This is a revised RFC version of my event handling API proposal.
> 
> It consists of 10 rather uninteresting preparatory, stylistic
> and bugfix patches, plus 3 with some meat in:
>   02/13  libxenstore: Provide xs_check_watch
>   12/13  libxl: New API for providing OS events to libxl
>   13/13  libxl: New event generation API
> 
> This series contains an implementation of almost everything, and
> builds apart from the lack of libxl_event_free, but it has not been
> executed at all.

> 
> So at this stage a very detailed code review, particularly of 12 and
> 13 is probably not appropriate.  However, this is hopefully a
> near-final version of the external and internal interfaces so it would
> be worth looking at those.

I reviewed all but #12 and #13 so far and I think they can mostly go in
now, at least in principal. I acked the majority with that in mind.

I suppose the ones which introduce new facilities should/could wait for
the actual users (which I presume are in #12 and #13) which I guess was
your intent but I think #1, #3, #5, #8, #10 and #11 would be obviously
fine right now.

#3 is a bit borderline wrt having a user but I think you wanted
libxl_qmp.c to use it so bashing it in now makes sense?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel