Re: [Xen-devel] [PATCH] libxl: allow to enable/disable cpuid bits

[Tim Deegan <tim@xxxxxxx>]

At 10:23 +0100 on 02 Nov (1320229392), Christoph Egger wrote:
> On 11/01/11 20:07, Ian Jackson wrote:
> >Christoph Egger writes ("[Xen-devel] [PATCH] libxl: allow to 
> >enable/disable cpuid bits"):
> >>
> >>Allow to enable/disable SVM specific cpuid bits
> >>in the guest config file via cpuid config option.
> >>Also allow to enable/disable the hypervisor cpuid bit
> >>in the guest config file. We need to disable the
> >>hypervisor cpuid bit to get Hyper-V going.
> >
> >The change itself looks plausible to me.  However I don't know much
> >about cpuid; can you get an ack from a hypervisor maintainer or an
> >suitable expert ?
> 
> Keir? Tim?

I think the hypervisor bit should be given a better name than 'raz' --
although it is read-as-zero on real hardware that doesn't distinguish it
from other raz bits, or describe what it does. 

'hypervisor' maybe, to match 'X86_FEATURE_HYPERVISOR' elsewhere in the
Xen code? 

With that change, Acked-by: Tim Deegan <tim@xxxxxxx>

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel