Re: [Xen-devel] [Qemu-devel] [PATCH 1/4] xen: introduce mc146818rtcxen

[Anthony Liguori <anthony@xxxxxxxxxxxxx>]

On 11/18/2011 05:46 AM, Stefano Stabellini wrote:
> On Tue, 15 Nov 2011, Stefano Stabellini wrote:
> > On Tue, 15 Nov 2011, Anthony Liguori wrote:
> > > On 11/15/2011 08:51 AM, stefano.stabellini@xxxxxxxxxxxxx wrote:
> > > > From: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>
> > > >
> > > > Xen doesn't need full RTC emulation in Qemu because the RTC is already
> > > > emulated by the hypervisor. In particular we want to avoid the timers
> > > > initialization so that Qemu doesn't need to wake up needlessly.
> > > >
> > > > Signed-off-by: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>
> > > Yuck.  There's got to be a better way to do this.
> > Yeah, it is pretty ugly, I was hoping in some good suggestions to
> > improve this patch :)
> >
> >
> > > I think it would be better to name timers and then in Xen specific machine code,
> > > disable the RTC timers.
> > Good idea!
> > I was thinking that I could implement an rtc_stop function in
> > mc146818rtc.c that stops and frees the timers.
You could also just stop the rtc_clock.  The rtc is the only device that makes 
use of the rtc_clock.
Regards,

Anthony Liguori

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel