Re: [Xen-devel] [PATCH] x86/vioapic: clear remote IRR when switching RTE to edge triggered mode

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 21/11/2011 08:17, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> Xen itself (as much as Linux) relies on this behavior, so it should
> also emulate it properly. Not doing so reportedly gets in the way of
> kexec inside a HVM guest.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Tested-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/arch/x86/hvm/vioapic.c
> +++ b/xen/arch/x86/hvm/vioapic.c
> @@ -154,8 +154,9 @@ static void vioapic_write_redirent(
>      {
>          vlapic_adjust_i8259_target(d);
>      }
> -    else if ( (ent.fields.trig_mode == VIOAPIC_LEVEL_TRIG) &&
> -              !ent.fields.mask &&
> +    else if ( ent.fields.trig_mode == VIOAPIC_EDGE_TRIG )
> +        pent->fields.remote_irr = 0;
> +    else if ( !ent.fields.mask &&
>                !ent.fields.remote_irr &&
>                hvm_irq->gsi_assert_count[idx] )
>      {
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel