Re: [Xen-devel] [PATCH 2/5] xen: Add privcmd device driver

[Bastian Blank <bastian@xxxxxxxxxxxx>]

On Mon, Nov 28, 2011 at 04:26:53PM +0000, Ian Campbell wrote:
> I wonder if we could do something dumb like make /proc/xen/privcmd by a
> symlink to /dev/xen/privcmd instead of introducing this cross module
> dependency?

Sure. However this make a dependency from kernel to the userspace naming
policy. And the xenfs module still needs some sort of dependency on
privcmd, so it gets loaded.

> The main reason would be to avoid the select since selecting on user
> visible symbols is a recipe for confusion and is generally advised
> against.

Right. It is just the easiest solution.

> Perhaps the xen-privcmd.ko should simply call a newly introduced
> xenfs_register()? This would be a nop if CONFIG_XENFS=n and therefore
> the select would not be necessary. If COFIG_XENFS=[my] then modprobe
> will do the right thing.

This would be not backward compatible. And I'd like to avoid a
dependency from privcmd to xenfs.

Bastian

-- 
Not one hundred percent efficient, of course ... but nothing ever is.
                -- Kirk, "Metamorphosis", stardate 3219.8

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel