Re: [Xen-devel] [PATCH 1 of 2] After preparing a page for page-in, allow immediate fill-in of the page contents

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andres Lagar-Cavilla writes ("[PATCH 1 of 2] After preparing a page for 
page-in, allow immediate fill-in of the page contents"):
> -    /* OP_ENABLE */
> -    uint64_aligned_t shared_addr;  /* IN:  Virtual address of shared page */
> +    union {
> +        /* OP_ENABLE IN:  Virtual address of shared page */
> +        uint64_aligned_t shared_addr;  
> +        /* PAGING_PREP IN: buffer to immediately fill page in */
> +        uint64_aligned_t buffer;
> +    } u;

Do we care that this interface is very binary-incompatible ?  Is there
a flag or version somewhere where we can at least arrange for this to
be detected ?  Perhaps we should allocate a new domctl number for this
version, so old code gets "no idea what you're talking about" rather
than wrong behaviour ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel