Re: [Xen-devel] [RFC] KEXEC: allocate crash note buffers at boot time v3

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 01/12/2011 12:56, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> +    register_keyhandler('C', &crashdump_trigger_keyhandler);
>> +
>> +    /* If no crash area, no need to allocate space for notes. */
>> +    if ( 0 == kexec_crash_area.size )
>> +        return 0;
> 
> Wouldn't it make sense to switch the order of these?

I also really hate this constant-first ordering.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel