Re: [Xen-devel] [PATCH 5 of 9] x86/mm: Ensure maps used by nested hvm code cannot be paged out

[Tim Deegan <tim@xxxxxxx>]

At 06:29 -0800 on 01 Dec (1322720982), Andres Lagar-Cavilla wrote:
> >> This can (at least theoretically) fail, and you must handle failure (or
> >> explain in a comment why not).
> >
> > Also, you should probably be using get_page(pg, d); is there any
> > reason to skip the ownership check?
> 
> Shared pages, owner could be dom_cow. Could conditionally get_page if
> writable, page_get_owner_and_ref if non writable.

That's probably best, plus a comment saying why.  

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel