Re: [Xen-devel] [PATCH 11 of 18] Tools: Allow libxl/xl to expose the total number of shared frames and space saved

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andres Lagar-Cavilla writes ("[PATCH 11 of 18] Tools: Allow libxl/xl to expose 
the total number of shared frames and space saved"):
> diff -r 6f489a294a76 -r cde3529132c1 tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -38,6 +38,7 @@
>  
>  #include "libxl.h"
>  #include "libxl_utils.h"
> +#include "libxl_internal.h"

No, this is not correct.  xl should not include libxl_internal.h.  Nor
should it make libxc calls directly.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel