Re: [Xen-devel] [PATCH 14/15] libxl: New API for providing OS events to libxl

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 9 Dec 2011, Ian Jackson wrote:
> All of the details in that paragraph are there because they not
> otherwise clear.  In particular, there are many semantic details which
> need to be covered.  It's precisely because there are so many
> important details to state, that it's not helpful to restate in
> sentences in comments things which have already been stated in the
> choice of function and parameter names.
> 
> But I can add a sentence about "user" if that would help:
> 
>    *
>    * The value of user is stored by libxl and passed to the callbacks.
> 
> Would that address this objection ?

Yes, that would help.

Maybe something similar for the parameters of the functions in
libxl_osevent_hooks, in particular for_app_registration_update.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel