Re: [Xen-devel] [PATCH] VT-d: bind IRQs to CPUs local to the node the IOMMU is on

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 13/12/2011 08:23, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> On 12.12.11 at 18:50, Keir Fraser <keir@xxxxxxx> wrote:
>> On 12/12/2011 15:53, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> 
>>> This extends create_irq() to take a node parameter, allowing the
>>> resulting IRQ to have its destination set to a CPU on that node right
>>> away, which is more natural than having to post-adjust this (and
>>> get e.g. a new IRQ vector assigned despite a fresh one was just
>>> obtained).
>>> 
>>> All other callers of create_irq() pass NUMA_NO_NODE for the time being.
>> 
>> I don't know about this one. Does the current 'inefficient' way things work
>> really matter?
> 
> The depends on the NUMA interconnect. My general perspective on
> this is that whenever NUMA locality information is available, we should
> aim at making use of it (unless it conflicts with something else*). And
> there's certainly ways to go in this respect.

Oh, I misunderstood the patch comment, and thought we *were* already
post-adjusting the affinity. But we're not, so this patch does make sense.

Acked-by: Keir Fraser <keir@xxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel