Re: [Xen-devel] [PATCH 0 of 3 V2] libxl: domain shutdown cleanup

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-12-16 at 09:51 +0000, Ian Campbell wrote:
> The existing libxl_domain_shutdown is a bit odd, it takes an integer
> "req" which can be used to indicate one of:
>   * [0] = "poweroff",
>   * [1] = "reboot",
>   * [2] = "suspend",
>   * [3] = "crash",
>   * [4] = "halt",
> 
> "suspend" is not usable via this interface since it requires other
> scaffolding, libxl_domain_suspend provides this already.
> 
> "halt" is the same as "poweroff".
> 
> "crash" is unused and at least Linux does not implement it. If a user
> steps forward then libxl_domain_crash is trivial to add.
> 
> Therefore split libxl_domain_shutdown into libxl_domain_shutdown and
> libxl_domain_reboot corresponding to "poweroff" and "reboot"
> respectively.
> 
> Also push responsibility for dealing with lack of PV drivers into the
> caller and at the same time improve the error messages presented to
> the user when they try and "xl shutdown/reboot" an HVM guest with no
> PV drivers and the corresponding documentation.

Forgot to save before hg email, should have said:

Changes since last time:
  - Remove massive redundancy in libxl_domain_{shutdown,reboot}

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel