Re: [Xen-devel] X86-MCE: fix a bug of xen-mceinj tool

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

>>      mca_cpuinfo(xc_interface *xc_  { struct xen_mc mc;
>> 
>> +    memset(&mc, 0, sizeof(struct xen_mc));
> 
> I doubt this is really needed.
> 
>> +
>>      mc.cmd = XEN_MC_physcpuinfo;
>> -    if (xc_mca_op(xc_handle, &mc))
>> +    mc.interface_version = XEN_MCA_INTERFACE_VERSION;
> 
> Wouldn't this rather belong into xc_mca_op()?
> 
> Jan
> 

Yes, not necessary, update as attached.

Thanks,
Jinsong

==================
X86-MCE: fix a bug of xen-mceinj tool

Fix a bug of xen-mceinj tool which used to test mce by software way.

Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>

diff -r 86defe150053 tools/tests/mce-test/tools/xen-mceinj.c
--- a/tools/tests/mce-test/tools/xen-mceinj.c   Fri Dec 16 16:24:31 2011 +0800
+++ b/tools/tests/mce-test/tools/xen-mceinj.c   Fri Dec 16 22:33:26 2011 +0800
@@ -135,7 +135,7 @@ static int mca_cpuinfo(xc_interface *xc_
     struct xen_mc mc;
 
     mc.cmd = XEN_MC_physcpuinfo;
-    if (xc_mca_op(xc_handle, &mc))
+    if (!xc_mca_op(xc_handle, &mc))
         return mc.u.mc_physcpuinfo.ncpus;
     else
         return 0;

Attachment: mceinj-tools-fix.patch
Description: mceinj-tools-fix.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel