Re: [Xen-devel] [PATCH 2 of 5] build: detect uclibc

[William Pitcock <nenolod@xxxxxxxxxxxxxxxx>]

Hi,

On Sun, Dec 18, 2011 at 6:48 AM, Roger Pau Monne
<roger.pau@xxxxxxxxxxxxx> wrote:
> # HG changeset patch
> # User Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
> # Date 1324171782 -3600
> # Node ID c54c326d6fdf26d311c872479b769b3a8cd560cf
> # Parent  eed78eb655c40b0ac9af1b14c1cc03204f696b0b
> build: detect uclibc
>
> Detect uclibc build environment and define CONFIG_UCLIBC accordingly.
>
> Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
>
> diff -r eed78eb655c4 -r c54c326d6fdf Config.mk
> --- a/Config.mk Sun Dec 18 02:29:42 2011 +0100
> +++ b/Config.mk Sun Dec 18 02:29:42 2011 +0100
> @@ -18,6 +18,8 @@ XEN_TARGET_ARCH     ?= $(XEN_COMPILE_ARC
>  XEN_OS              ?= $(shell uname -s)
>
>  CONFIG_$(XEN_OS) := y
> +CONFIG_UCLIBC    := $(shell gcc -dumpmachine | grep -c uclibc \
> +                      | sed -e s/[^0]/y/ -e s/0/n/)

I don't like this approach as it introduces an explicit dependency on
gcc just to find out if we're on uclibc or not.  Please find a
different way to do this.  Checking for
/usr/include/bits/uClibc_config.h should be sufficient, e.g.

$(shell test -f /usr/include/bits/uClibc_config.h && echo 'y' || echo 'n')

This approach would be cleaner, please use it instead.

William

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel