[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] libxl: add support for yajl 2.x



On Thu, 2011-12-22 at 15:48 +0000, Keir Fraser wrote:
> On 22/12/2011 15:28, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> >> diff -r f72b99fccfca -r 716d6d48e647 Config.mk
> >> --- a/Config.mk Tue Dec 20 08:31:40 2011 +0100
> >> +++ b/Config.mk Tue Dec 20 13:52:55 2011 +0100
> >> @@ -186,6 +186,11 @@ CONFIG_LIBICONV   := $(shell export OS="
> >>                         . $(XEN_ROOT)/tools/check/funcs.sh; \
> >>                         has_lib libiconv.so && echo 'y' || echo 'n')
> >>  
> >> +CONFIG_YAJL_VERSION := $(shell export OS="`uname -s`"; \
> >> +                       export CHECK_INCLUDES="$(CHECK_INCLUDES)"; \
> >> +                       . $(XEN_ROOT)/tools/check/funcs.sh; \
> >> +                       has_header yajl/yajl_version.h && echo 'y' || echo
> >> 'n')
> > 
> > We've ended up with a few of this sort of thing recently. I wonder if it
> > is time to have a configuration/check phase which generates a config.h?
> 
> Perhaps there should be autotools machinery at the root of the tree, in
> place of Config.mk etc? It seems the popular choice.

"Popular" isn't quite the right word, "common" maybe. It's generally
pretty loathed. But, yes, something along those lines maybe.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.