Re: [Xen-devel] Stubdom build problem in 4.1.2 but not in xen-unstable

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-12-23 at 09:32 +0000, Jan Beulich wrote:
> >>> On 23.12.11 at 10:25, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > I thought "inline" was just a hint so it seems odd that gcc would error
> > out.
> 
> That's what -Winline is for - to tell you that your intention to have a
> function inlined wasn't fulfilled. If one asks for this warning,
> occasionally having the compiler emit it is the result. The question to
> me is what the purpose was to enable that warning in the first place.

It seems to be only extras/mini-os which uses it and it came from the
first changeset, copy Samuel in case he remembers why.

Whatever the reason this specific instance is surely not worth force
inlining.

Linux uses __attribute__((always_inline)) and various similar
constructs, presumably to work around varying behaviours across gcc's.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel