Re: [Xen-devel] [PATCH v4 14/25] arm: driver for CoreLink GIC-400 Generic Interrupt Controller

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 10 Jan 2012, Ian Campbell wrote:
> On Mon, 2012-01-09 at 17:59 +0000, stefano.stabellini@xxxxxxxxxxxxx
> wrote:
> > 
> > +static unsigned int gic_irq_startup(struct irq_desc *desc)
> > +{
> > +    uint32_t enabler;
> > +       int irq = desc->irq;
> > + 
> 
> Some hard tabs appear to have snuck in at least a couple of times in
> this file and elsewhere:
> $ find xen/arch/arm/ xen/include/asm-arm/ -name \*.[ch] | xargs grep '     ' 
> -l
> xen/arch/arm/smp.c
> xen/arch/arm/lib/bitops.h
> xen/arch/arm/irq.c
> xen/arch/arm/gic.c
> xen/arch/arm/vtimer.c
> xen/arch/arm/setup.c
> xen/arch/arm/domain.c
> xen/include/asm-arm/numa.h
> xen/include/asm-arm/grant_table.h
> xen/include/asm-arm/div64.h
> 
> I think hard tabs are OK in code from Linux (e.g.
> xen/arch/arm/lib/bitops.h) and in .S files but not elsewhere.
 
Agreed, evidently my smart vim runes are not smart enough.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel