Re: [Xen-devel] [PATCH 13/18] xenstored: support running in minios stubdom

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 13/18] xenstored: support running 
in minios stubdom"):
> One thing which might help is to provide nop versions of functions
> instead of idef'ing both the definition and callsite. e.g. 
>  static void write_pidfile(const char *pidfile)
> +#ifndef __MINIOS__
>      stuff
> +#else
> +    nothing
> +endif

I would normally prefer:

> +#ifndef __MINIOS__
>  static void write_pidfile(const char *pidfile)
>      stuff
>  }
> +#else
> +static void write_pidfile(const char *pidfile)
> +}
> +endif

I think this is fairly easy to read; the only hard part is figuring
out which version is being used, which can often be done by putting
the relevant bits in a separate file.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel