Re: [Xen-devel] [PATCH 06 of 12] x86/mm: New domctl: add a shared page to the physmap

[Tim Deegan <tim@xxxxxxx>]

Hi, 

At 21:56 -0500 on 15 Jan (1326664586), Andres Lagar-Cavilla wrote:
> +int mem_sharing_add_to_physmap(struct domain *sd, unsigned long sgfn, 
> shr_handle_t sh,
> +                            struct domain *cd, unsigned long cgfn) 
> +{
> +    struct page_info *spage;
> +    int ret = -EINVAL;
> +    mfn_t smfn, cmfn;
> +    p2m_type_t smfn_type, cmfn_type;
> +    struct gfn_info *gfn_info;
> +    struct p2m_domain *p2m = p2m_get_hostp2m(cd);
> +    p2m_access_t a;
> +    DECLARE_PG_LOCK_DATA(pld);
> +    
> +    /* XXX if sd == cd handle potential deadlock by ordering
> +     * the get_ and put_gfn's */

You fixed this in the other case; please fix this one too. :)

Otherwise this looks OK.

Cheers,

Tim.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel