Re: [Xen-devel] [PATCH 07/12] xen: allow tmem to be disabled on platforms which do not support it (ARM)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-01-20 at 12:36 +0000, Jan Beulich wrote:
> >>> On 20.01.12 at 13:28, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Fri, 2012-01-20 at 12:19 +0000, Stefano Stabellini wrote:
> >> Why do we need this?
> >> I though that tmem compiled OK on ARM.
> > 
> > But it can't possibly work, as evidenced by the missing symbol in
> > dummy.S! There is no point in compiling something which cannot work.
> 
> But introducing random HAS_xyz variables isn't that pretty either. The
> more that the term 'has' seems wrong to me in this case.

yeah, I was copy the other similar variables. Probably ENABLE would be
better in this case.

> By just not wiring up the hypercall you could achieve the same effect.

Really? I'd still need to ifdef out the hypercall body or I'd get
unresolved symbols, wouldn't I?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel