Re: [Xen-devel] [PATCH] xenpaging: unify return value in nominate and evict

[Olaf Hering <olaf@xxxxxxxxx>]

On Mon, Jan 30, Tim Deegan wrote:

> I don't think EAGAIN is the right thing to return here.  There's no
> reason to think that retrying an invalid GFN will work next time. 
> 
> I'd be happy for these cases all to return the same code, but maybe
> EINVAL would be a better choice. 

EINVAL is returned by upper layers already. I think both nominate and
evict should return EBUSY in case of failure, this is most likely unique
enough to mean "request reached target function, and failed.".

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel