[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] amd iommu: disable iommu emulation on non-iommu systems

On 02/03/2012 03:11 PM, Jan Beulich wrote:
On 03.02.12 at 15:09, Wei Wang<wei.wang2@xxxxxxx>  wrote:
On 02/01/2012 04:58 PM, Jan Beulich wrote:
... Further, are the extra checks needed at all
(i.e. wouldn't domain_iommu() return NULL in all of these cases
anyway due to the same checks being added to guest_iommu_init())?
If so, the checks you add to guest_iommu_destroy() are pointless

It is just to make sure those functions are not called by an unexpected
code path since it is non-static. But I can remove it if you prefer that.

Keir already committed the patch, but converting things like this
(where the impossible is being checked) to assertions is preferred
imo (meaning less redundant, possibly dead code in production
builds), so a follow-up patch would be appreciated.
No problem. Do it right away.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.